Fix validation for containerapp name#6407
Merged
zhoxing-ms merged 1 commit intoAzure:mainfrom Jun 15, 2023
Merged
Conversation
|
Hi @yash-nisar, |
ghost
requested a review
from 
ghost
added
the
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
yash-nisar
force-pushed
the
name_validation
branch
from
cc6ed25 to
9514969
Compare
Greedygre
approved these changes
Jun 15, 2023
yash-nisar
force-pushed
the
name_validation
branch
from
9514969 to
71ef0d2
Compare
zhoxing-ms
approved these changes
Jun 15, 2023
Contributor
|
@Greedygre Could you please help review this PR again? |
Greedygre
reviewed
Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.